Closed Bug 1622664 Opened 5 years ago Closed 5 years ago

nsJSProtocolHandler.cpp: redundant access specifier has the same accessibility as the previous access specifier

Categories

(Developer Infrastructure :: Source Code Analysis, task)

task
Not set
minor

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: Sylvestre, Assigned: nmkiggundu, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

 protected:
  nsCOMPtr<nsIChannel> mStreamChannel;

redundant access specifier has the same accessibility as the previous access specifier
here, protected is declared twice

https://searchfox.org/mozilla-central/source/dom/jsurl/nsJSProtocolHandler.cpp#369-378

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-access-specifiers.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Norah, you already fixed bug 1622663
These bugs are to learn workflow, please leave them for others, thanks :)

Hi Sylvestre,
This would be my first bugfix in firefox. I'm somewhat comfortable with c++, do you think it's okay if I take this one.

harikrishnan527: Sure! Good luck!

(In reply to Sylvestre Ledru [:Sylvestre] from comment #2)

Norah, you already fixed bug 1622663
These bugs are to learn workflow, please leave them for others, thanks :)

Sure thing Sylvestre. Thanks a lot!

hey Sylvestre...
Tiny doubt I had...I should be able to use git-cinnabar to test and submit the patch right?

Yeah, the doc in comment #0 should have everything.

Norah, thanks. You could have a look to harder good first bugs :)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #7)

Yeah, the doc in comment #0 should have everything.

Norah, thanks. You could have a look to harder good first bugs :)

Alright Syvestre

Assignee: nobody → nmkiggundu
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0684efa1e1f2 Removed redundant access specifier on line 378. r = sylvestre r=emilio
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: