nsJSProtocolHandler.cpp: redundant access specifier has the same accessibility as the previous access specifier
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: nmkiggundu, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
protected:
nsCOMPtr<nsIChannel> mStreamChannel;
redundant access specifier has the same accessibility as the previous access specifier
here, protected is declared twice
https://searchfox.org/mozilla-central/source/dom/jsurl/nsJSProtocolHandler.cpp#369-378
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-access-specifiers.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D68020
Reporter | ||
Comment 2•5 years ago
|
||
Norah, you already fixed bug 1622663
These bugs are to learn workflow, please leave them for others, thanks :)
Comment 3•5 years ago
|
||
Hi Sylvestre,
This would be my first bugfix in firefox. I'm somewhat comfortable with c++, do you think it's okay if I take this one.
Reporter | ||
Comment 4•5 years ago
|
||
harikrishnan527: Sure! Good luck!
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to Sylvestre Ledru [:Sylvestre] from comment #2)
Norah, you already fixed bug 1622663
These bugs are to learn workflow, please leave them for others, thanks :)
Sure thing Sylvestre. Thanks a lot!
Comment 6•5 years ago
|
||
hey Sylvestre...
Tiny doubt I had...I should be able to use git-cinnabar to test and submit the patch right?
Reporter | ||
Comment 7•5 years ago
|
||
Yeah, the doc in comment #0 should have everything.
Norah, thanks. You could have a look to harder good first bugs :)
Assignee | ||
Comment 8•5 years ago
|
||
(In reply to Sylvestre Ledru [:Sylvestre] from comment #7)
Yeah, the doc in comment #0 should have everything.
Norah, thanks. You could have a look to harder good first bugs :)
Alright Syvestre
Updated•5 years ago
|
Comment 10•5 years ago
|
||
bugherder |
Updated•3 years ago
|
Description
•